This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Fix GeoJSONVTData ownership and life cycle #16106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the
GeoJSONVTData
instance was retained at the scheduledlambda, which run on the worker thread represented by the
GeoJSONVTData::scheduler
class member:
It caused program termination in case
self
turned to be the last reference tothis
,as the
std::thread
destructor was called from the thread it represented.Now, only the
GeoJSONVTData::impl
class member is retained.Fixes: #16101