-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Delete old iOS, macOS codebases; clean up CMake configuration #16228
Conversation
As a side benefit, the baselines build is showing that the size of mbgl-glfw, mbgl-offline, and mbgl-render has gone down by 12%, 23%, and 12%, respectively. diff --git a/metrics/binary-size/macos-xcode11/metrics.json b/metrics/binary-size/macos-xcode11/metrics.json
index 7bd94ba99..3c7bafd20 100644
--- a/metrics/binary-size/macos-xcode11/metrics.json
+++ b/metrics/binary-size/macos-xcode11/metrics.json
@@ -3,17 +3,17 @@
[
"mbgl-glfw",
"/tmp/attach/install/macos-xcode11-release/bin/mbgl-glfw",
- 5677792
+ 4989624
],
[
"mbgl-offline",
"/tmp/attach/install/macos-xcode11-release/bin/mbgl-offline",
- 5542252
+ 4290368
],
[
"mbgl-render",
"/tmp/attach/install/macos-xcode11-release/bin/mbgl-render",
- 5588368
+ 4904264
]
]
}
\ No newline at end of file |
Nice, thanks @1ec5! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@1ec5 thank you for this. Is it also possible to apply the patch generated by the baseline bot and also remove the files?
b3b8db9
to
aa8e7d6
Compare
aa8e7d6
to
ec5b8d0
Compare
I’ve deleted all the dead code I could find, along with unused resources and scripts. In the course of performing refactors, @mapbox/gl-native has been editing the abandoned iOS/macOS map SDK codebase that this PR is deleting. Not all of these changes have made their way to the gl-native-ios repository. I tried my best to port over these changes in mapbox/mapbox-gl-native-ios#181, with the caveat that I’ve only upgraded to v1.2.0 so far. Any changes since then, like #16238, still need to be ported when we upgrade again. If you’ve made any changes that weren’t in response to a compiler error or test failure, please double-check that mapbox/mapbox-gl-native-ios#181 contains your changes. Thanks! |
For historical reasons, developers may come here when looking for the Mapbox Maps SDK. Direct them to the right repository so they don’t get confused thinking Mapbox only provides a C++ library.
ec5b8d0
to
2e005fd
Compare
A little housekeeping:
/cc @mapbox/maps-ios @tmpsantos