Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[android] Add jni binding for min and max pitch #16236

Merged
merged 2 commits into from
Feb 28, 2020
Merged

Conversation

Chaoba
Copy link
Contributor

@Chaoba Chaoba commented Feb 26, 2020

min and max pitch method will be added to android sdk. This pr add the jni binding for them. The related pr in map sdk: mapbox/mapbox-gl-native-android#199

@Chaoba Chaoba self-assigned this Feb 26, 2020
@Chaoba Chaoba requested a review from tobrun February 27, 2020 01:09
@tobrun tobrun requested review from a team, astojilj and tmpsantos and removed request for a team February 27, 2020 09:23
Copy link
Contributor

@alexshalamov alexshalamov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please add description to a PR.

@chloekraw
Copy link
Contributor

chloekraw commented Feb 27, 2020

@Chaoba before you release any changes, please make sure the changelog is up to date and tag me for review.

@Chaoba
Copy link
Contributor Author

Chaoba commented Feb 28, 2020

@chloekraw Change log update done.

@Chaoba Chaoba merged commit e0c2b3e into master Feb 28, 2020
@Chaoba Chaoba deleted the kl-min-max-pitch branch February 28, 2020 09:26
alexshalamov pushed a commit that referenced this pull request Feb 28, 2020
* [android] Add jni binding for min and max pitch

* Update CHANGELOG.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants