This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core][tile mode] Reduce cut-off labels #16336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pozdnyakov
force-pushed
the
mikhail_placement_fixes
branch
from
fa41a2d
to
11ca744
Compare
pozdnyakov
force-pushed
the
mikhail_placement_fixes
branch
from
11ca744
to
eced1c9
Compare
alexshalamov
approved these changes
Mar 24, 2020
pozdnyakov
force-pushed
the
mikhail_placement_fixes
branch
2 times, most recently
from
33ac39a
to
b7c79af
Compare
…yers Thus, we reduce the amount of label cut-offs in Tile mode. Before, labels were arranged within one symbol layer (one bucket), which was not enough for several symbol layers being placed at the same time.
Thus we obviate lots of repeated operations for already placed symbols.
pozdnyakov
force-pushed
the
mikhail_placement_fixes
branch
from
b7c79af
to
4b178ef
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Place tile intersecting labels first, across all the layers. Thus, we reduce the amount of label cut-offs in Tile mode.
Before, labels were arranged within one symbol layer (one bucket), which was not enough for several symbol layers being placed at the same time.
Partial fix for https://github.com/mapbox/mapbox-gl-native-team/issues/223