Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Bundle boost #20

Closed
wants to merge 2 commits into from
Closed

Bundle boost #20

wants to merge 2 commits into from

Conversation

springmeyer
Copy link
Contributor

Since we currently only use boost::variant it makes sense to bundle just this part of boost. It only adds 8MB, which I think is well worth the current and future convenience of not needing an external boost.

Luckily boost is designed for this: the bcp tool is able to extract all possible headers all platforms might need for #include <boost/variant.hpp>

I created this bundle from boost 1.55 by doing:

./dist/bin/bcp boost/variant.hpp ~/projects/llmr-native/include/

@kkaefer
Copy link
Member

kkaefer commented Jan 30, 2014

Mh, not sure about this; it increases the repo size dramatically. Given that boost is easy to install by just typing brew install boost, and we're not relying on an up-to-date version of boost, for now, I'd like to not include this. I'm also not sure about staying on boost::variant for Value types since we likely need better comparisons (e.g. string to integer comparisons, and float/integer comparisons), so we might have to do a custom implementation for the value type.

@incanus
Copy link
Contributor

incanus commented Jan 30, 2014

Yeah, this is large. For our current platforms, brew install boost is enough. BTW the Brew Boost works just fine for the ARM builds I was doing over in #12. We are just using header-only stuff right now, right?

@springmeyer
Copy link
Contributor Author

Sounds good, closing. The GYP pull (#21) now also has a configure script to make it easy to point at any custom boost location, which helps make this easier.

@springmeyer springmeyer deleted the bundle-boost branch May 27, 2014 16:08
@mb12 mb12 mentioned this pull request Oct 29, 2014
@PreviousTlx PreviousTlx mentioned this pull request Apr 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants