You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we currently only use boost::variant it makes sense to bundle just this part of boost. It only adds 8MB, which I think is well worth the current and future convenience of not needing an external boost.
Luckily boost is designed for this: the bcp tool is able to extract all possible headers all platforms might need for #include <boost/variant.hpp>
Mh, not sure about this; it increases the repo size dramatically. Given that boost is easy to install by just typing brew install boost, and we're not relying on an up-to-date version of boost, for now, I'd like to not include this. I'm also not sure about staying on boost::variant for Value types since we likely need better comparisons (e.g. string to integer comparisons, and float/integer comparisons), so we might have to do a custom implementation for the value type.
Yeah, this is large. For our current platforms, brew install boost is enough. BTW the Brew Boost works just fine for the ARM builds I was doing over in #12. We are just using header-only stuff right now, right?
Sounds good, closing. The GYP pull (#21) now also has a configure script to make it easy to point at any custom boost location, which helps make this easier.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we currently only use boost::variant it makes sense to bundle just this part of boost. It only adds 8MB, which I think is well worth the current and future convenience of not needing an external boost.
Luckily boost is designed for this: the bcp tool is able to extract all possible headers all platforms might need for
#include <boost/variant.hpp>
I created this bundle from
boost 1.55
by doing:./dist/bin/bcp boost/variant.hpp ~/projects/llmr-native/include/