This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios] Refactor MGLMapView's location services #4034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (showsUserLocation == _showsUserLocation || _isTargetingInterfaceBuilder) return; | ||
|
|
||
| _showsUserLocation = showsUserLocation; | ||
| BOOL shouldEnableLocationServices = !self.locationManager && self.showsUserLocation; |
There was a problem hiding this comment.
Validation methods shouldn’t have preconditions. This flag should additionally check for self.dormant, such that you could call this method twice in a row without producing the opposite result.
|
@friedbunny 👍 although for "Only ask for location permissions if not already granted/denied" the CLLocationManager API already guards against redundant requests although this certainly does not hurt anything. |
|
@boundsj Aye, checking for |
friedbunny
force-pushed
the
fb-location-init-refactor-v3.1.2
branch
from
9381ff2 to
15b9f31
Compare
friedbunny
changed the title
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #3641, rebased onto the
release-ios-v3.1.0branch for the upcoming v3.1.2 release..isDormant→.dormant.Partially addresses #2945, for which a full and complete fix waits until #4030.
/cc @1ec5 @boundsj