Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

iosapp UI tests #4837

Closed
wants to merge 15 commits into from
Closed

iosapp UI tests #4837

wants to merge 15 commits into from

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Apr 25, 2016

Added a UI test bundle that uses XCUITest to test iosapp. The bundle contains some basic tests of annotation functionality. Gather code coverage data in the iosapp and dynamic schemes.

Added accessibility identifiers for key controls in the SDK and iosapp.

  • Add UI test bundle
  • Suppress access token prompt if necessary
  • Test gestures
  • Test point annotations
  • Test shape annotations (blocked by Multipoint annotations should be accessible to VoiceOver #4838)
  • Test callout views
  • Test compass
  • Test user tracking modes
  • Test user dot
  • Test ℹ️ actions
  • Test offline pack table view controller
  • Add UI test bundle to CI scheme

Working towards #4794.

/cc @friedbunny @boundsj

@1ec5 1ec5 self-assigned this Apr 25, 2016
@1ec5 1ec5 added iOS Mapbox Maps SDK for iOS tests labels Apr 25, 2016
@1ec5 1ec5 added this to the ios-v3.3.0 milestone Apr 25, 2016
@1ec5 1ec5 force-pushed the 1ec5-xcuitest-4794 branch 3 times, most recently from d1fcb14 to 25e03dd Compare April 27, 2016 01:09
@1ec5
Copy link
Contributor Author

1ec5 commented Apr 27, 2016

The three existing test suites currently take 113.7 seconds. Once we implement all the tests, the tests might end up taking too long to run on Bitrise for every push, forcing us to run the tests only in the nightly workflow. The biggest time sink right now is the fact that XCUITest relaunches the application before every single test.

@friedbunny
Copy link
Contributor

The biggest time sink right now is the fact that XCUITest relaunches the application before every single test.

That’s been my experience elsewhere, too. For now, we could write fewer, larger tests.

@1ec5 1ec5 force-pushed the 1ec5-xcuitest-4794 branch 2 times, most recently from d0be80c to 3d4c58e Compare April 27, 2016 22:25
@1ec5 1ec5 force-pushed the 1ec5-xcuitest-4794 branch 2 times, most recently from cdcffa8 to da5be1c Compare May 3, 2016 21:59
@1ec5 1ec5 mentioned this pull request May 4, 2016
1ec5 added 14 commits May 5, 2016 01:07
Added a UI test bundle that uses XCUITest to test iosapp. The bundle contains some basic tests of annotation functionality. Gather code coverage data in the iosapp and dynamic schemes.

Added accessibility identifiers for key controls in the SDK and iosapp.

Working towards #4794.
Assigned titles to the world tour annotations.
Test the rotation gesture and the compass. Bypass the access token prompt by filling in a bogus access token.
All the test cases now inherit from a single XCTestCase subclass that implements the pre-test cleanup procedure.
During UI tests, disable UI tests and skip state restoration so we don’t have to reset the position for each test.
Added a test that cycles among the user tracking modes and tests for the presence and size of the user dot or user puck in each mode. Simulate a current location in San Francisco. Added more accessibility identifiers to iosapp.
Also wait to use settings sheet until after it appears.
The user dot rests at a different location depending on the screen size. Instead of hard-coding the center of a 4½″ iPhone, just make sure the user dot isn’t underlapping the Settings button.
Also log the user dot’s frame.
@1ec5 1ec5 mentioned this pull request May 26, 2016
@friedbunny friedbunny modified the milestones: ios-v3.4.0, ios-v3.3.0 Jun 24, 2016
@boundsj boundsj modified the milestones: ios-v3.4.0, ios-future Jul 11, 2016
@1ec5 1ec5 added the ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold label Mar 25, 2017
@jfirebaugh
Copy link
Contributor

Stale.

@jfirebaugh jfirebaugh closed this Oct 24, 2017
@jfirebaugh jfirebaugh deleted the 1ec5-xcuitest-4794 branch October 24, 2017 20:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold iOS Mapbox Maps SDK for iOS tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants