Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Add Mapbox Jazzy theme #5306

Merged
merged 4 commits into from
Jul 1, 2016
Merged

Add Mapbox Jazzy theme #5306

merged 4 commits into from
Jul 1, 2016

Conversation

friedbunny
Copy link
Contributor

@friedbunny friedbunny commented Jun 10, 2016

Based on Jazzy's fullwidth theme.

To-do

This is a good start, but there are more improvements to be made:

Going forward

Jazzy allows for arbitrary prose sections written in Markdown that include the same code highlighting, so we could even consider moving the examples or guides into here, too. This could be a good opportunity to write specific feature sections that focus on complex features such as offline or annotations.

Main page

mapbox ios sdk reference 20160622
First draft.

MGLMapView

mglmapview class reference 20160622
First draft.

/cc @danswick @1ec5 @cammace @boundsj @frederoni

@friedbunny friedbunny added iOS Mapbox Maps SDK for iOS documentation labels Jun 10, 2016
@friedbunny friedbunny added this to the ios-v3.3.0 milestone Jun 10, 2016
@friedbunny friedbunny self-assigned this Jun 10, 2016
@1ec5
Copy link
Contributor

1ec5 commented Jun 10, 2016

Hide empty/broken “Other Type Definitions” section.

#3957

@1ec5
Copy link
Contributor

1ec5 commented Jun 10, 2016

Jazzy allows for arbitrary prose sections written in Markdown that include the same code highlighting, so we could even consider moving the examples or guides into here, too.

That’s realm/jazzy#435, released just a few hours ago in jazzy 0.6.3 (upgrade now!). I’m strongly in favor of doing this, because it makes our examples that much more discoverable to Dash users. The examples would likely be maintained in this repository, where the broader community can help maintain and expand them. Also, it would allow us to eventually replace the entire /ios-sdk site with the jazzy documentation (with an online-specific readme, perhaps), streamlining navigation considerably.

@friedbunny
Copy link
Contributor Author

friedbunny commented Jun 11, 2016

Ellipsized extra-long navigation items, though I believe @1ec5 disapproves of my methods. 😁

screen shot 2016-06-10 at 2 57 28 pm

@friedbunny
Copy link
Contributor Author

friedbunny commented Jun 11, 2016

realm/jazzy#590 may fix #3957.

@friedbunny
Copy link
Contributor Author

Going to give this Jazzy theme another look after evaluating the new Apple documentation style, see if there’s anything to borrow.

@friedbunny
Copy link
Contributor Author

friedbunny commented Jun 22, 2016

SourceKit is the cause of UnsafeMutablePointer swallowing the rest of the method signature, per realm/jazzy#536. No up-upstream issue exists yet.

This is where the problem manifests for us: when we use a pointer to a struct, such as in -[MGLMapView setVisibleCoordinates:count:edgePadding:animated:] with CLLocationCoordinate2D:

- (void)setVisibleCoordinates:(CLLocationCoordinate2D *)coordinates count:(NSUInteger)count edgePadding:(UIEdgeInsets)insets animated:(BOOL)animated;

@friedbunny
Copy link
Contributor Author

friedbunny commented Jun 22, 2016

Made this more Mapboxy by using Open Sans for the text — screencaps have been updated. (Though, Paparazzi doesn’t seem to do a good job rendering... some link colors are off, smallcaps isn’t working, and some SVGs are weird. Oh well.)

@friedbunny friedbunny force-pushed the fb-jazzy-theme branch 2 times, most recently from 531a644 to 16151c6 Compare June 28, 2016 20:51
@friedbunny
Copy link
Contributor Author

Rebased and squashed this down to the essential commits. The iOS screenshot is still a placeholder, pending me actually coming up with something that decently illustrates polylines.

Also added macOS support:

screen shot 2016-06-28 at 4 24 22 pm

... had to fake a macos tag in order for it to build.

@cammace
Copy link
Contributor

cammace commented Jun 28, 2016

Wow this looks great @friedbunny, can't wait to see it live!

@1ec5
Copy link
Contributor

1ec5 commented Jun 28, 2016

Don’t forget to note the new design in the changelog for both SDKs!

- Based on Jazzy's "full width" theme.
- Add ellipsis to overlong items in navigation menu.
- Set minimum width for navigation menu.
- Use Open Sans font face.
- Inline GitHub header icon as SVG.
- Center images by default.
- Add GitHub SVG icon to 'show on github' link.
- Wrap overlong method names on class pages.
- Don't use an absolute URL for the screenshot image, include the file instead.
- Add Sketch document for screenshot.
@friedbunny friedbunny merged commit 388fdd2 into release-ios-v3.3.0 Jul 1, 2016
@friedbunny friedbunny deleted the fb-jazzy-theme branch July 1, 2016 21:49
@friedbunny
Copy link
Contributor Author

screen shot 2016-07-01 at 5 52 55 pm

@friedbunny
Copy link
Contributor Author

For anyone wanting to update the iOS screenshots, there’s a new Sketch file at platform/ios/originals/screenshots.sketch that includes the frame and images.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants