This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Fix overdraw mode on Linux #5534
Merged
+351
−352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoabinader
force-pushed
the
brunoabinader-overdraw-linux-crash
branch
from
01742ba to
e6a9cf0
Compare
brunoabinader
force-pushed
the
brunoabinader-overdraw-linux-crash
branch
from
e6a9cf0 to
cd37991
Compare
- Use glBindAttribLocation for GLSL attributes. - Create a separate shader for each shader that supports overdraw. Needed because each uniform location must be known for every program. - Create a separate VAO for each shader inside buckets. Needed because we can only bind a VAO to a specific shader. Fixes #5435.
brunoabinader
force-pushed
the
brunoabinader-overdraw-linux-crash
branch
from
cd37991 to
f4c3611
Compare
|
Any reason for renaming the shader variables? |
You mean a17b0bc#diff-c4566dff12c9f7a41bf5c7e847a3fa95R24 ? If so, the reason was because we needed an alias for the current shader in use, which could be either the original or overdraw shader. I used a different name to avoid name clashing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed because each uniform location must be known for every program.
Needed because we can only bind a VAO to a specific shader.
Grabbed some shader cleanups from #5532 - thanks @kkaefer!
Fixes #5435.
👀 @kkaefer @jfirebaugh @zugaldia @tmpsantos