This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Offline storage size API #5585
Merged
Offline storage size API #5585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedbunny
added a commit
that referenced
this pull request
Jul 7, 2016
We cannot guarantee that the offline/ambient tile cache (cache.db) will be created in a timely manner, so it's safer to set the backup exclusion key on its containing directory. But, because we placed cache.db in the base of the app's Application Support directory (where backups are expected to be allowed), we need to move cache.db into a directory that we control and can exclude from backups with impunity. This is an amalgam of #5578 (directory exclusion) and #5585 (refactored URL methods, but without the new database size method). Also: * Prefix mapbox subdirectory with dot, for extra safety * Update changelog entry with new ticket, less speculation
1ec5
force-pushed
the
1ec5-offline-size-5580
branch
from
57dd3e3 to
3fb5a5d
Compare
Added a property to MGLOfflineStorage that indicates the disk space occupied by all cached and offline resources. Fixes #5580.
1ec5
force-pushed
the
1ec5-offline-size-5580
branch
from
3fb5a5d to
1bc4f0e
Compare
|
Cherry-picked to the release-ios-v3.3.0 branch as e421180. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a property to MGLOfflineStorage that indicates the disk space occupied by all cached and offline resources.
Fixes the iOS side of #5580.
/cc @friedbunny @jfirebaugh @zugaldia