This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Quadkey tokens in tile URL templates, limited WMS support #5628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 9, 2016
1ec5
changed the title
|
The WMS test is failing due to what appears to be a double rounding discrepancy. (Formatting floats has long been a painful topic in gl-native: #5054.) Does it matter that (x0, y0, z1) produces: instead of the GL JS expected value of: /cc @kkaefer |
| @@ -55,6 +89,8 @@ Resource Resource::tile(const std::string& urlTemplate, | |||
| int8_t z, | |||
| Necessity necessity) { | |||
| bool supportsRatio = urlTemplate.find("{ratio}") != std::string::npos; | |||
| auto quadKey = getQuadKey(x, y, z); | |||
There was a problem hiding this comment.
Move getQuadKey and getTileBBox into the lambda conditionals, so they are only called if needed.
1ec5
force-pushed
the
1ec5-quadkey-5485
branch
2 times, most recently
from
dbb7403 to
d1cf19d
Compare
|
Going to assume the discrepancy doesn’t matter because these are projected meters. If anyone has a problem with gl-native being a nanometer off gl-js in both directions, we can address that as tail work. |
Added a style to the macosapp resource bundle that can be used to test WMS support. To use it, zoom in to somewhere in New Jersey, then go to View ‣ Custom Style and enter “wms.json”.
Closed
|
@1ec5 given that these units are Spherical Mercator meters, the slight discrepancy doesn't matter, since it's just 1 nanometer at the equator. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported mapbox/mapbox-gl-js#2805 and mapbox/mapbox-gl-js@0877cac to support quadkey tokens in tile URL templates.
Ported mapbox/mapbox-gl-js#2612 (comment) along with the necessary parts of mapbox/whoots-js@f2ca0ca for limited WMS scheme support. Added a local style to macosapp that you can use to debug WMS support in the macOS SDK: zoom in to New Jersey, then go to View ‣ Custom Style and enter
wms.json.Fixes #822 and fixes #5485.
/cc @lucaswoj @tmcw @bhousel