Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Update Runtime Style JavaDoc #6573

Merged
merged 2 commits into from
Oct 5, 2016
Merged

Update Runtime Style JavaDoc #6573

merged 2 commits into from
Oct 5, 2016

Conversation

ivovandongen
Copy link
Contributor

Fixes #6510
Fixes #6542

@ivovandongen ivovandongen added Android Mapbox Maps SDK for Android documentation labels Oct 4, 2016
@ivovandongen ivovandongen self-assigned this Oct 4, 2016
@mention-bot
Copy link

@ivovandongen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @incanus, @tobrun and @kkaefer to be potential reviewers.

@ivovandongen ivovandongen added the ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold label Oct 4, 2016
@ivovandongen ivovandongen added this to the android-v4.2.0 milestone Oct 4, 2016
@ivovandongen ivovandongen changed the title Update JavaDoc Update Runtime Style JavaDoc Oct 4, 2016
@ivovandongen ivovandongen force-pushed the ivovandongen-javadoc branch 2 times, most recently from 25a00fa to bef9a21 Compare October 4, 2016 15:14
@ivovandongen
Copy link
Contributor Author

@tobrun Think I got all the issues from #5610 and #6542. Maybe not perfect yet (could indeed use some examples here and there), but I think we should iterate on that. Let me know what you think.

@ivovandongen ivovandongen added ✓ ready for review and removed ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold labels Oct 4, 2016
tobrun
tobrun approved these changes Oct 5, 2016
View reviewed changes
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for picking this up! The language improvements are making it easier for me to understand what the API actually does! :shipit:

@ivovandongen ivovandongen merged commit dd7713f into master Oct 5, 2016
@1ec5 1ec5 mentioned this pull request Oct 7, 2016
Closed
@friedbunny friedbunny deleted the ivovandongen-javadoc branch October 7, 2016 16:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tobrun tobrun tobrun approved these changes

Assignees

@ivovandongen ivovandongen

Labels
Android Mapbox Maps SDK for Android documentation
Projects
None yet
Milestone
android-v4.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ivovandongen @mention-bot @tobrun