Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Consistify runtime styling category prefix: mbgl_ → mgl_ #6701

Closed
wants to merge 1 commit into from

Conversation

friedbunny
Copy link
Contributor

Fixes #6078. This makes runtime styling category method naming consistent with the rest of the SDK.

/cc @1ec5 @frederoni

This makes runtime styling category method naming consistent with the rest of the SDK.
@friedbunny friedbunny added iOS Mapbox Maps SDK for iOS refactor macOS Mapbox Maps SDK for macOS runtime styling labels Oct 14, 2016
@friedbunny friedbunny added this to the ios-v3.4.0 milestone Oct 14, 2016
@friedbunny friedbunny self-assigned this Oct 14, 2016
@mention-bot
Copy link

@friedbunny, thanks for your PR! By analyzing the history of the files in this pull request, we identified @1ec5, @frederoni and @incanus to be potential reviewers.

Copy link
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but almost all of these methods will go away with #6601 anyways.

@friedbunny
Copy link
Contributor Author

@1ec5 Shall we hold this until after #6601, then? The changes here are trivial and it’d likely be easier to fix-up this PR later than worry about merge conflicts elsewhere.

@1ec5
Copy link
Contributor

1ec5 commented Oct 14, 2016

Yes, that would be ideal. Thank you.

@1ec5
Copy link
Contributor

1ec5 commented Oct 16, 2016

I’ve cherry-picked all the good parts into #6601.

@friedbunny
Copy link
Contributor Author

Alright, then! ✌️

@friedbunny friedbunny closed this Oct 17, 2016
@friedbunny friedbunny deleted the fb-mgl-prefix-consistify branch October 17, 2016 16:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS refactor runtime styling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants