This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[node] Revert semantics of Map#render #7098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jfirebaugh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kkaefer, @mikemorris and @ansis to be potential reviewers. |
jfirebaugh
force-pushed
the
revert-node-api
branch
from
4c9a5d3 to
cd4165b
Compare
mikemorris
suggested changes
Nov 17, 2016
| @@ -66,6 +71,15 @@ module.exports = function (style, options, callback) { | |||
| wait(); | |||
|
|
|||
| } else { | |||
| // Ensure that the next `map.render(options)` does not overwrite this change. | |||
There was a problem hiding this comment.
Would a check for setPitch be necessary here too?
There was a problem hiding this comment.
It's not required by test-suite yet, but might as well. ✅
jfirebaugh
force-pushed
the
revert-node-api
branch
from
1c6840b to
a902b99
Compare
jfirebaugh
force-pushed
the
revert-node-api
branch
from
a902b99 to
5c7aeec
Compare
mikemorris
approved these changes
Nov 17, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert node
Map#renderAPI to "stateless" camera semantics: the center, zoom, bearing, and pitch passed are what is used to render, with defaults for unspecified values.For the test-suite implementation, which wants stateful semantics, track the camera options manually. Also, change the implementation of
Map#renderso that it avoids callingsetCenter, etc. when the value is not changing. (Internally,setCenterdoes not short-circuit, so it could cause undesired updates.)cc @mikemorris