[core] Polylabel-based "pole of inaccessibility" symbol placement #7465
Conversation
|
@jfirebaugh, thanks for your PR! By analyzing this pull request, we identified @tmpsantos, @ansis and @springmeyer to be potential reviewers. |
jfirebaugh
force-pushed
the
polylabel
branch
2 times, most recently
from
bc6e768 to
70eaab7
Compare
| } | ||
|
|
||
| // 16 here represents 2 pixels |
There was a problem hiding this comment.
I copied this comment from mapbox/mapbox-gl-js@5318f35#diff-621f09c210ab28c3dbf7bc1f0f03c6b2R365. I suppose it derives from the relationship between normalized tile extent of 8192 and nominal tile pixel size of 512. @lucaswoj?
There was a problem hiding this comment.
Ok; can we replace this with the symbolic constants that we're using throughout GL native?
There was a problem hiding this comment.
Doesn't 16 equal 1 pixel though? 8192/512=16
There was a problem hiding this comment.
This code originates from mapbox/mapbox-gl-js#2678 by @blanchg. I don't have any knowledge beyond what's been discussed here so far.
There was a problem hiding this comment.
That parameter is the accuracy threshold, I.e. stop searching if the target size reaches 16 or less. @mourner helped me to identify that. Is it possible at the time we were working off of 256 tiles?
jfirebaugh
force-pushed
the
polylabel
branch
from
70eaab7 to
a9d4eef
Compare
jfirebaugh
force-pushed
the
polylabel
branch
from
a9d4eef to
1bb80c0
Compare
Fixes #6115