-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[ios] Set project deployment target to iOS 8 #8129
Conversation
@friedbunny, thanks for your PR! By analyzing this pull request, we identified @1ec5, @incanus and @boundsj to be potential reviewers. |
73555a3
to
464f2ef
Compare
To be clear, we currently have no plans to drop the static framework and will provide advance notice before doing so. |
@@ -52,8 +52,6 @@ bash "${BUILT_PRODUCTS_DIR}/${FRAMEWORKS_FOLDER_PATH}/Mapbox.framework/strip-fra | |||
|
|||
#### Static framework | |||
|
|||
If your application targets iOS 7.x, you’ll need to install the static framework instead: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd leave in a sentence just to make it clear that these are alternative instructions, not additive. "If you need a static framework…"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I struggled to come up with anything here — “if you can’t say anything nice...” 😉
Will revisit this tomorrow. Very open to detailed suggestions!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here’s the “You know who you are” version:
You can alternatively install the SDK as a static framework:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did this in a1c477b.
464f2ef
to
ac0e2e0
Compare
With Xcode 8 having dropped support for iOS 7 and Apple declaring it dangerously insecure, it’s come time to move our minimum deployment version to iOS 8.
Notes
/cc @mapbox/ios