More robust Mapbox Streets label localization #9063
Conversation
Added Arabic, Portuguese, and Simplified Chinese to the list of languages with specialized fields in the Mapbox Streets source. Rely on NSBundle to select the most appropriate locale based on the user’s preferred languages.
1ec5
added
iOS
| forPreferences:[NSLocale preferredLanguages]]; | ||
| NSString *mostSpecificLanguage; | ||
| for (NSString *language in preferredLanguages) { | ||
| if (language.length > mostSpecificLanguage.length) { |
There was a problem hiding this comment.
How robust do you think picking the longest match is? I suppose we’d have to rethink this a bit if we ever added support for, e.g., zh-Hant.
There was a problem hiding this comment.
This is sort of a hack to prioritize zh-Hans in the case where the preference is zh-*. Confusingly, the +[NSBundle preferredLocalizationsFromArray:forPreferences:] documentation claims that the method in this case returns:
typically either a single non-region-specific localization or a region-specific localization followed by a corresponding non-region-specific localization as a fallback
whereas preferredLanguages actually ends up with the value ["zh", "zh-Hans"].
Unfortunately, it is the case that, when the preference is zh-Hant or zh-Hant-*, preferredLanguages ends up being ["en"]. If we do add a zh-Hant, zh-Hant-TW will correctly match zh-Hant, however.
/ref lionheart/openradar-mirror#4831 (rdar://problem/14228383)
Rely on NSBundle to select the most appropriate locale based on the user’s preferred languages. This code is used in iosapp’s “Label Countries In” demonstration and macosapp’s View ‣ Labels In setting. (#7031 tracks folding that logic into the SDKs proper.)
Added Arabic, Portuguese, and Simplified Chinese to the list of languages with specialized fields in the Mapbox Streets source, based on this revised document. The previous logic was insufficient for choosing between
zhandzh-Hans./cc @friedbunny