This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios] Expose setCamera with padding #9651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
boundsj
reviewed
Aug 2, 2017
There was a problem hiding this comment.
This looks good to me since it only exposes a new API with no effective change to the existing internal behavior.
Tagging in @friedbunny and @fabian-guerra for an additional set of 👀 . I'm ready to approve after they review.
friedbunny
suggested changes
Aug 2, 2017
friedbunny
force-pushed
the
fred-expose-setcamera-padding
branch
from
00ad425 to
0b17fcc
Compare
friedbunny
approved these changes
Aug 2, 2017
boundsj
approved these changes
Aug 3, 2017
|
Added this issue to the macOS parity tracking project. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new camera method that takes
edgePaddingas a parameter to overcome the default insetscontentInsetswhich insets the ornaments like compass and attribution.