Skip to content

Commit

Permalink
Remove sonarqube integration (#1290)
Browse files Browse the repository at this point in the history
  • Loading branch information
danesfeder authored Sep 13, 2018
1 parent 8af4616 commit 64ef9ac
Show file tree
Hide file tree
Showing 6 changed files with 1 addition and 30 deletions.
3 changes: 0 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
checkstyle:
./gradlew checkstyle

sonarqube:
./gradlew sonarqube

test:
# See libandroid-navigation/build.gradle for details
./gradlew :libandroid-navigation:test
Expand Down
4 changes: 0 additions & 4 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,6 @@ android {
}
}

sonarqube {
skipProject = true
}

dependencies {
// Mapbox Navigation SDK
implementation project(':libandroid-navigation-ui')
Expand Down
5 changes: 1 addition & 4 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ buildscript {
}
dependencies {
classpath pluginDependencies.gradle
classpath pluginDependencies.sonarqube
classpath pluginDependencies.coveralls
classpath pluginDependencies.errorprone
classpath pluginDependencies.dependencyUpdates
Expand Down Expand Up @@ -46,6 +45,4 @@ subprojects {

task clean(type: Delete) {
delete rootProject.buildDir
}

apply from: "${rootDir}/gradle/sonarqube.gradle"
}
3 changes: 0 additions & 3 deletions circle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,6 @@ jobs:
- run:
name: Run unit-test and generate Jacoco test report
command: ./gradlew createDebugUnitTestCoverageReport
# - run:
# name: Sonarcloud upload
# command: make sonarqube
- run:
name: Build release to test ProGuard rules
command: ./gradlew app:assembleRelease
Expand Down
2 changes: 0 additions & 2 deletions gradle/dependencies.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ ext {
errorprone : '0.0.13',
coveralls : '2.8.1',
spotbugs : '1.3',
sonarqube : '2.6-rc1',
gradle : '3.1.2',
dependencyGraph : '0.3.0',
dependencyUpdates: '0.20.0'
Expand Down Expand Up @@ -108,7 +107,6 @@ ext {
gradle : "com.android.tools.build:gradle:${pluginVersion.gradle}",
checkstyle : "com.puppycrawl.tools:checkstyle:${pluginVersion.checkstyle}",
spotbugs : "gradle.plugin.com.github.spotbugs:gradlePlugin:${pluginVersion.spotbugs}",
sonarqube : "org.sonarsource.scanner.gradle:sonarqube-gradle-plugin:${pluginVersion.sonarqube}",
coveralls : "org.kt3k.gradle.plugin:coveralls-gradle-plugin:${pluginVersion.coveralls}",
errorprone : "net.ltgt.gradle:gradle-errorprone-plugin:${pluginVersion.errorprone}",
dependencyGraph : "com.vanniktech:gradle-dependency-graph-generator-plugin:${pluginVersion.dependencyGraph}",
Expand Down
14 changes: 0 additions & 14 deletions gradle/sonarqube.gradle

This file was deleted.

0 comments on commit 64ef9ac

Please sign in to comment.