-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flaky NavigationViewOrientationTest #1209
Comments
Run into the following Line 79 in 0854e8e
|
Run into a new crash when requesting Mapbox Directions API during CI Instrumentation Tests
|
… of its flakiness (#1209) and make it more robust
Run into a new crash during CI Instrumentation Tests
|
@Guardiola31337 would it make sense to store a "backup" route JSON to be used in cases where the Directions API fails for whatever reason? |
That's a great idea and would solve the issue but have we considered using always a TestDouble here? Ultimately, the Instrumentation Tests are not meant for testing the integration with a server side API because that translates to tests that have a large scope and are prone to failure / non-deterministic / flaky (👀 FIRST concretely the BTW we should definitely add a different test suite for testing API integrations (using MockWebServer for example) although that's another discussion. |
Cross posting from #1241 (comment) Run into 👇 during CI Instrumentation Tests
It seems that #1247 didn't solve OP. We should keep 🕵️ Going to re-edit OP to reflect ☝️ cc @danesfeder |
…of its flakiness (#1209) and make it more robust
… of their flakiness (#1209) and make them more robust
Re-edited:
Original issue is still reproducible 👀 #1209 (comment)
✅ Addressed in #1247Found 👇 during CI Instrumentation Tests
It seems that we're suffering from an occasional race condition in
OnNavigationReadyIdlingResource
when fetching the route and initializingNavigationView
inTestNavigationActivity
andnavigationView.initialize
is called twice somehow causing theCannotAddSourceException
crash.Noting that I saw the error coming from both tests in
NavigationViewOrientationTest
(onOrientationLandscape_navigationContinuesRunning
andonOrientationPortrait_navigationContinuesRunning
) and only in Firebase Test Lab.For context, these tests were introduced in #1179
The text was updated successfully, but these errors were encountered: