Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add distance remaining buffer to show first instruction immediately #1043

Merged
merged 1 commit into from
Jun 21, 2018
Merged

Add distance remaining buffer to show first instruction immediately #1043

merged 1 commit into from
Jun 21, 2018

Conversation

danesfeder
Copy link
Contributor

@danesfeder danesfeder commented Jun 21, 2018 •
edited
Loading

Closes #1038

distanceAlongGeometry: 244.7, stepDistanceRemaining: 244.71726738470264

^ First instruction wasn't showing when no progress was made along the route. Rounding the distance remaining shows the instruction immediately at the start of the route.

@danesfeder danesfeder added bug Defect to be fixed. navigation-ui labels Jun 21, 2018
@danesfeder danesfeder added this to the 0.15.0 milestone Jun 21, 2018
@danesfeder danesfeder self-assigned this Jun 21, 2018
@danesfeder danesfeder force-pushed the dan-first-instruction branch 2 times, most recently from 9dd24aa to 39010f4 Compare June 21, 2018 18:54
Guardiola31337
Guardiola31337 approved these changes Jun 21, 2018
View reviewed changes
Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a precision problem so we should revisit why all variables types aren't aligned. Noticed that we're converting some variables to double for example and I don't know why.

@danesfeder danesfeder merged commit 6da69cb into master Jun 21, 2018
@danesfeder danesfeder deleted the dan-first-instruction branch June 21, 2018 19:50
@danesfeder danesfeder mentioned this pull request Jun 21, 2018
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guardiola31337 Guardiola31337 Guardiola31337 approved these changes

@devotaaabel devotaaabel Awaiting requested review from devotaaabel

Assignees

@danesfeder danesfeder

Labels
bug Defect to be fixed.
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@danesfeder @Guardiola31337