Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Transifex translations #1078

Merged
merged 1 commit into from
Jul 2, 2018
Merged

Update Transifex translations #1078

merged 1 commit into from
Jul 2, 2018

Conversation

danesfeder
Copy link
Contributor

Closes #1077

Pulled down new translations and pushed updated variable naming from #1076

@danesfeder danesfeder added this to the 0.16.0 milestone Jul 2, 2018
@danesfeder danesfeder self-assigned this Jul 2, 2018
@danesfeder danesfeder requested a review from Guardiola31337 July 2, 2018 19:06
@danesfeder danesfeder force-pushed the dan-transifex-update branch from e02b333 to 4866343 Compare July 2, 2018 19:15
@Guardiola31337
Copy link
Contributor

At this point this PR doesn't close #1077

Don’t want the community to translate the "new" string again. As explained it'd be great to

  • Update the key in Transifex

or

  • Force push the already translated strings.xml files (with the new key)

@danesfeder
Copy link
Contributor Author

@Guardiola31337 noting that the updated key was pushed and the translations in TX were not erased

@Guardiola31337
Copy link
Contributor

noting that the updated key was pushed and the translations in TX were not erased

Great. Thanks for confirming.

As you pointed out, it seems that Transifex doesn't care about the keys themselves (only the actual words being translated). Apparently, it sees a diff and the actually strings in the XML are the same and then just takes the new key.

We're good here. Thanks @danesfeder for dealing with this.

@danesfeder danesfeder merged commit 468a931 into master Jul 2, 2018
@danesfeder danesfeder deleted the dan-transifex-update branch July 2, 2018 19:36
@1ec5
Copy link
Contributor

1ec5 commented Jul 2, 2018

As you pointed out, it seems that Transifex doesn't care about the keys themselves (only the actual words being translated). Apparently, it sees a diff and the actually strings in the XML are the same and then just takes the new key.

On the contrary, keys are what Transifex uses to identify a translation. So if the key is renamed in this repository, it’ll show up as a new, untranslated string across all localizations. Translators would then go in and accept the 💯 match that Transifex suggests thanks to translation memory.

@Guardiola31337
Copy link
Contributor

@1ec5

On the contrary, keys are what Transifex uses to identify a translation.

That's what I initially thought and I'd expect.

Translators would then go in and accept the 100 match that Transifex suggests thanks to translation memory.

What about the translations with the old key?

Also, I didn't accept anything. You @danesfeder? Could we know who accepted the match? I ask because apparently in this case was done automatically somehow by Transifex.

@1ec5
Copy link
Contributor

1ec5 commented Jul 2, 2018

It takes a little while for Transifex to pick up the changes in master. Now that it has picked up the changes, a bunch of localizations have four strings needing translation.

The old translations for title_navigation_view_ui will not be suggested for title_navigation_launcher, because the new base value “Navigation Launcher” is too different from the original “Navigation Views”. “Navigation Launcher” will need a different translation anyways.

@Guardiola31337
Copy link
Contributor

It takes a little while for Transifex to pick up the changes in master. Now that it has picked up the changes, a bunch of localizations have four strings needing translation.

Ohhhh, that makes sense.

The old translations for title_navigation_view_ui will not be suggested for title_navigation_launcher, because the new base value “Navigation Launcher” is too different from the original “Navigation Views”. “Navigation Launcher” will need a different translation anyways.

Correct, I wasn't expecting title_navigation_view_ui and title_navigation_launcher to match, actually the first key was replaced with the latter. Does that mean that we also need to remove title_navigation_view_ui (not valid anymore) somehow? I was wondering what happened with description_navigation_view_ui and description_navigation_launcher. We only changed the key but not the translations so they match 💯

Going to reopen #1077 until we ensure that we only have two strings in Transifex - title_navigation_launcher needing translations and description_navigation_launcher accepting the matches because old and new translations haven't changed at all.

@danesfeder danesfeder mentioned this pull request Jul 20, 2018
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants