-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Transifex translations #1078
Conversation
e02b333
to
4866343
Compare
At this point this PR doesn't close #1077 Don’t want the community to translate the "new" string again. As explained it'd be great to
or
|
@Guardiola31337 noting that the updated key was pushed and the translations in TX were not erased |
Great. Thanks for confirming. As you pointed out, it seems that Transifex doesn't care about the keys themselves (only the actual words being translated). Apparently, it sees a diff and the actually strings in the XML are the same and then just takes the new key. We're good here. Thanks @danesfeder for dealing with this. |
On the contrary, keys are what Transifex uses to identify a translation. So if the key is renamed in this repository, it’ll show up as a new, untranslated string across all localizations. Translators would then go in and accept the 💯 match that Transifex suggests thanks to translation memory. |
That's what I initially thought and I'd expect.
What about the translations with the old key? Also, I didn't accept anything. You @danesfeder? Could we know who accepted the match? I ask because apparently in this case was done automatically somehow by Transifex. |
It takes a little while for Transifex to pick up the changes in master. Now that it has picked up the changes, a bunch of localizations have four strings needing translation. The old translations for |
Ohhhh, that makes sense.
Correct, I wasn't expecting Going to reopen #1077 until we ensure that we only have two strings in Transifex - |
Closes #1077
Pulled down new translations and pushed updated variable naming from #1076