Update MapboxNavigationNotification to consider 24 hour time formatting #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Noticed that TimeFormatter#formatArrivalTime is no longer used. I guess that we should remove it - in theory, it'd break SemVer and would require a major version bump but because we're in a 0.x version I think we can safely do it, what do you think?
Other than that this looks good to me 👍
danesfeder
force-pushed
the
dan-notification-24
branch
from
bebc787
to
2fb5e1d
Compare
|
@Guardiola31337 Yup, good call - updated 👀 |
Guardiola31337
added
the
backwards incompatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1098
MapboxNavigationNotificationwill now look atMapboxNavigationOptionsfor a provided time format preference. If not provided, it will use the device default.