Fix navigation events #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danesfeder
reviewed
Sep 28, 2017
| } | ||
|
|
||
| public MapboxNavigation(@NonNull Context context, @NonNull String accessToken, | ||
| @NonNull MapboxNavigationOptions options, boolean isFromNavigationUi) { |
There was a problem hiding this comment.
@cammace Do you think it would be cleaner to add a boolean isFromNavigationUi to MapboxNavigationOptions rather than adding a parameter to the constructor?
There was a problem hiding this comment.
@danesfeder 1867c75 addresses your comment.
danesfeder
reviewed
Sep 28, 2017
| String userAgent = String.format("%s/%s", sdkIdentifier, BuildConfig.MAPBOX_NAVIGATION_VERSION_NAME); | ||
| MapboxTelemetry.getInstance().initialize(context, accessToken, userAgent, sdkIdentifier, | ||
| BuildConfig.MAPBOX_NAVIGATION_VERSION_NAME); | ||
| MapboxTelemetry.getInstance().newUserAgent(userAgent); |
There was a problem hiding this comment.
@Guardiola31337 Should we take care of setting the user agent for the UI here as well (now that we know if we are initializing from the UI or not)? Rather than when I initialize in NavigationView https://github.com/mapbox/mapbox-navigation-android/blob/master/navigation/libandroid-navigation-ui/src/main/java/com/mapbox/services/android/navigation/ui/v5/NavigationView.java#L428
There was a problem hiding this comment.
…g on where they come from (navigation or navigation-ui)
Guardiola31337
force-pushed
the
pg-fix-turnstile-events
branch
from
02425f5
to
1867c75
Compare
|
@Guardiola31337 Looks good to me, I like the use of |
cammace
approved these changes
Sep 28, 2017
danesfeder
approved these changes
Sep 28, 2017
Grsmto
pushed a commit
to Grsmto/mapbox-navigation-android
that referenced
this pull request
Oct 2, 2017
* master: Resolves several code issues (mapbox#287) removed OSRM-Text-Instructions (mapbox#288) readme bump to 0.6.1 (mapbox#282) 0.6.1 Release (mapbox#283) fix navigation events so that use the correct sdk identifier depending on where they come from (navigation or navigation-ui) (mapbox#277)
Grsmto
pushed a commit
to Grsmto/mapbox-navigation-android
that referenced
this pull request
Oct 3, 2017
* grs-fix-offroute-false-positive: (50 commits) add missing imports offroute detector should get the right upComingStep instead of the last step of the leg to do the calculation Resolves several code issues (mapbox#287) removed OSRM-Text-Instructions (mapbox#288) readme bump to 0.6.1 (mapbox#282) 0.6.1 Release (mapbox#283) fix navigation events so that use the correct sdk identifier depending on where they come from (navigation or navigation-ui) (mapbox#277) fix a bug where the snappedPoint lat/lng values are infinity if the step geometry is a single point (for example the last step of a leg) instead of a line string we don't need to enter in this condition if isOffRoute is false fix mockNavigation activity waypoints adding order + zoom level for easier testing add offroute event listener on mockLocation activity, so we can test this bumped version # in readme (mapbox#267) Release 0.6 (mapbox#262) Don't remove milestone listener on arrival / adjust arrival verbiage Update Camera tilt and MAS dependency (mapbox#261) unknown profile (mapbox#259) Bump up Navigation UI example / change log position (mapbox#260) Reduce Reroute Threshold (mapbox#251) Camera and location layer ignore null location (mapbox#252) User agent plus exit roundabout (mapbox#250) ... # Conflicts: # navigation/libandroid-navigation/src/main/java/com/mapbox/services/android/navigation/v5/navigation/DefaultMilestones.java # navigation/libandroid-navigation/src/main/java/com/mapbox/services/android/navigation/v5/navigation/NavigationHelper.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sdkIdentifierdepending on where they come from (mapbox-navigation-androidormapbox-navigation-ui-android)2.2.5👀 @zugaldia @cammace @danesfeder @electrostat