Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for null or empty String speechUrl before playing #475

Merged
merged 2 commits into from
Nov 9, 2017
Merged

Check for null or empty String speechUrl before playing #475

merged 2 commits into from
Nov 9, 2017

Conversation

danesfeder
Copy link
Contributor

  • Will happen in scenarios where our Polly requests fail

@danesfeder danesfeder added the bug Defect to be fixed. label Nov 8, 2017
@danesfeder danesfeder self-assigned this Nov 8, 2017
@danesfeder danesfeder merged commit bb77e09 into master Nov 9, 2017
@danesfeder danesfeder deleted the dan-polly-bug branch November 9, 2017 18:07
@danesfeder danesfeder mentioned this pull request Nov 13, 2017
Closed
9 tasks
Grsmto pushed a commit to Grsmto/mapbox-navigation-android that referenced this pull request Nov 14, 2017
Merge branch 'master' of https://github.com/mapbox/mapbox-navigation-…
4fb1f0b 
…android into fix-build

* 'master' of https://github.com/mapbox/mapbox-navigation-android:
  Bumped version number to 0.7.0 in readme (mapbox#496)
  Release 0.7.0  (mapbox#497)
  Portrait / landscape layouts are different. Only cast to View (mapbox#494)
  Add missing javadoc for feedback methods in MapboxNavigation (mapbox#493)
  Update lane stylekit and then maneuver bias (mapbox#492)
  Fix bug with bottom sheet behavior null onConfigChange (mapbox#490)
  Fix issue where new route was not being detected (mapbox#478)
  Add telem absolute distance to destination track support (mapbox#427)
  Adjust Instruction Content Layout XML (mapbox#465)
  Fix bug with bottomsheet not hiding in night mode (mapbox#483)
  Cleanup / javadoc (mapbox#479)
  Initialize click listeners after presenter / viewmodel is set (mapbox#481)
  Create SpanUtil and SpanItem to more easily format Strings for our views (mapbox#477)
  Check for null or empty String speechUrl before playing (mapbox#475)
  Update location layer to 0.2.0 and re-add as lifecycle observer (mapbox#473)
  Check for null raw location before setting bearing (mapbox#476)

# Conflicts:
#	libandroid-navigation/src/main/java/com/mapbox/services/android/navigation/v5/navigation/NavigationMetricsWrapper.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cammace cammace cammace approved these changes

@ericrwolfe ericrwolfe Awaiting requested review from ericrwolfe

Assignees

@danesfeder danesfeder

Labels
bug Defect to be fixed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danesfeder @cammace