Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Metric Listener Reset #566

Merged
merged 4 commits into from
Dec 4, 2017
Merged

Change Metric Listener Reset #566

merged 4 commits into from
Dec 4, 2017

Conversation

danesfeder
Copy link
Contributor

  • We were previously checking to reset the arrival / departure listener (if new leg) on every progress update
  • This PR adds the arrival listener only after the departure listener has fired
  • It also adds logic to reset the departure listener only when the arrival listener fires and if we aren't on the last leg

cc @ericrwolfe

@danesfeder danesfeder added the bug Defect to be fixed. label Dec 4, 2017
@danesfeder danesfeder self-assigned this Dec 4, 2017
@danesfeder danesfeder force-pushed the dan-duplicate-departure branch from e6db5ad to 04ed423 Compare December 4, 2017 20:05
@danesfeder danesfeder merged commit da0197a into master Dec 4, 2017
@danesfeder danesfeder deleted the dan-duplicate-departure branch December 4, 2017 22:11
@danesfeder danesfeder mentioned this pull request Dec 6, 2017
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericrwolfe ericrwolfe ericrwolfe approved these changes

@Guardiola31337 Guardiola31337 Guardiola31337 approved these changes

Assignees

@danesfeder danesfeder

Labels
bug Defect to be fixed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danesfeder @ericrwolfe @Guardiola31337