Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in Brazilian Portuguese localization file paths #730

Closed
wants to merge 2 commits into from

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Mar 2, 2018

File paths for the Brazilian Portuguese localization have a few typos.

/ref #657
/cc @danesfeder @langsmith

1ec5 added 2 commits March 2, 2018 01:29
…l to libandroid-navigation-ui/src/main/res/values-pt-BR/strings.xml
…o libandroid-navigation/src/main/res/values-pt-BR/strings.xml
@1ec5 1ec5 added bug Defect to be fixed. topic: localization labels Mar 2, 2018
@1ec5 1ec5 self-assigned this Mar 2, 2018
@1ec5 1ec5 requested a review from danesfeder March 2, 2018 09:33
@1ec5
Copy link
Contributor Author

1ec5 commented Mar 2, 2018

Builds are failing due to an invalid direction name, but I’m not sure why it was OK with pt-rBR, which is an invalid code:

/root/code/libandroid-navigation-ui/src/main/res/values-pt-BR: Error: Invalid resource directory name
:libandroid-navigation-ui:packageDebugResources FAILED

@1ec5
Copy link
Contributor Author

1ec5 commented Mar 2, 2018

Never mind… according to this Xamarin documentation, the Android localization format requires the r in front of the ISO 3166 code. 🤷‍♂️

@1ec5 1ec5 closed this Mar 2, 2018
@1ec5 1ec5 deleted the 1ec5-pt-rbr branch March 2, 2018 09:39
@danesfeder
Copy link
Contributor

@1ec5 Yeah ran into this when I was first setting up transifex. Had to add https://github.com/mapbox/mapbox-navigation-android/blob/master/.tx/config#L4 to map to the correct directory. Thanks for keeping an eye out regardless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defect to be fixed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants