Billing explanation logs #7747
Merged
Billing explanation logs #7747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChangelogFeatures
Bug fixes and improvementsKnown issues
|
Codecov ReportAttention:
@@ Coverage Diff @@
## main #7747 +/- ##
============================================
+ Coverage 74.11% 74.12% +0.01%
Complexity 6252 6252
============================================
Files 852 852
Lines 33672 33696 +24
Branches 4011 4012 +1
============================================
+ Hits 24955 24977 +22
- Misses 7167 7169 +2
Partials 1550 1550
|
|
LGTM. Will we document it somewhere? |
DzmitryFomchyn
approved these changes
Feb 14, 2024
| @@ -215,18 +217,23 @@ internal class BillingController( | |||
| is NavigationSessionState.Idle -> { | |||
| getRunningOrPausedSessionSkuId()?.let { | |||
| billingService.pauseBillingSession(it) | |||
| logI(BILLING_EXPLANATION_CATEGORY) { | |||
There was a problem hiding this comment.
@VysotskiVadim I think we can test it, and check that we print correct reason to logs.
There was a problem hiding this comment.
sure, we can!
Let's not announce this feature in public documentation until unit tests are in place.
DzmitryFomchyn
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From time to time customers asks us why they are billed for a certain amount of trip/freedrive sessions? This PR introduces answer to that question. A customer can filter logcat output using
BillingExplanationand see why exactly certain billed session started/stopped/paused/resumed.This is port of #7710 which has already helped to a customer.
Screenshots or Gifs