Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized TextToSpeech usage cherry-pick #7842

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

DzmitryFomchyn
Copy link
Contributor

Description

Cherry-picks #7833

* NAVAND-2991 - Optimized TextToSpeech usage

Moved language setting and speak calls to a background thread.

* Rename changelog files

* NAVAND-2991 - Optimized TextToSpeech usage

Unit-test fix

---------

Co-authored-by: runner <runner@fv-az1428-633>
@DzmitryFomchyn DzmitryFomchyn requested a review from a team as a code owner July 22, 2024 16:42
@DzmitryFomchyn DzmitryFomchyn requested a review from a team July 22, 2024 16:42
Copy link

Changelog

Features

Bug fixes and improvements

  • Fixed UI jank caused by on-device TextToSpeech player. [#7833](https://github.com/mapbox/mapbox-navigation-android/pull/7833)

Known issues ⚠️

Other changes

Android Auto Changelog

Features

Bug fixes and improvements

  • The app is now considered as the one in active navigation only when an active route is set to MapboxNavigation. Previously it was always considered active. [#7366](https://github.com/mapbox/mapbox-navigation-android/pull/7366)
  • When Android Auto host tells the app to stop active navigation because another app starts navigating, now SDK will enter FreeDrive mode instead of stopping trip session completely. [#7366](https://github.com/mapbox/mapbox-navigation-android/pull/7366)

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.17%. Comparing base (39a5265) to head (4e0f269).

Impacted file tree graph

@@               Coverage Diff                @@
##             release-v2.20    #7842   +/-   ##
================================================
  Coverage            74.16%   74.17%           
+ Complexity            6265     6262    -3     
================================================
  Files                  856      856           
  Lines                33779    33789   +10     
  Branches              4023     4023           
================================================
+ Hits                 25053    25062    +9     
- Misses                7168     7170    +2     
+ Partials              1558     1557    -1     
Files Coverage Δ
...gation/ui/voice/api/VoiceInstructionsTextPlayer.kt 82.02% <88.88%> (+1.00%) ⬆️

@DzmitryFomchyn DzmitryFomchyn merged commit dfa79e9 into release-v2.20 Jul 22, 2024
36 of 40 checks passed
@DzmitryFomchyn DzmitryFomchyn deleted the df-2991-cherry-pick branch July 22, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants