Added safety for NONE_SPECIFIED type for voice units #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
approved these changes
Mar 30, 2018
| @@ -14,7 +14,8 @@ | |||
| public class LocaleUtils { | |||
|
|
|||
| /** | |||
| * Returns the unit type for the specified locale | |||
| * Returns the unit type for the specified locale. Try to avoid using this unnecessarily because | |||
| * all methods consuming unit type are able to handle the NONE_SPECIFIED type | |||
| * @param locale for which to return the default unit type | |||
| * @return unit type for specified locale | |||
| */ | |||
There was a problem hiding this comment.
Minor thing annotations normally are on top of the method definition like 👇
@NavigationUnitType.UnitType
public static int getUnitTypeForLocale(@NonNull Locale locale) {👇
| @@ -20,7 +22,11 @@ | |||
| public static final int TYPE_IMPERIAL = 0; | |||
There was a problem hiding this comment.
NIT Empty lines #15 and #17 ☝️
| unitType = NavigationUnitType.getDirectionsCriteriaUnitType(options.navigationOptions().unitType()); | ||
| MapboxNavigationOptions navigationOptions = options.navigationOptions(); | ||
| unitType = NavigationUnitType.getDirectionsCriteriaUnitType( | ||
| navigationOptions.unitType(), locale); |
There was a problem hiding this comment.
NIT Why is this in a new line?
| @@ -20,7 +22,11 @@ | |||
| public static final int TYPE_IMPERIAL = 0; | |||
| public static final int TYPE_METRIC = 1; | |||
|
|
|||
| public static String getDirectionsCriteriaUnitType(int unitType) { | |||
| public static String getDirectionsCriteriaUnitType(int unitType, Locale locale) { | |||
There was a problem hiding this comment.
We're missing @NavigationUnitType.UnitType 👇
public static String getDirectionsCriteriaUnitType(@NavigationUnitType.UnitType int unitType, Locale locale) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #810