Add MapboxNavigationOptions to adjust location validation thresholds #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozyr
reviewed
Apr 3, 2018
| @@ -81,7 +81,8 @@ private boolean isAccuracyAcceptable(@NonNull Location location) { | |||
| boolean improvedAccuracy = currentAccuracy <= previousAccuracy; | |||
| boolean currentAccuracyWorse = currentAccuracy > previousAccuracy; | |||
| boolean hasSameProvider = lastValidLocation.getProvider().equals(location.getProvider()); | |||
| boolean lessThanPercentThreshold = (accuracyDifference <= (previousAccuracy / locationPercentAccuracyThreshold)); | |||
| double percentThreshold = locationPercentAccuracyThreshold / 100; | |||
There was a problem hiding this comment.
percentThreshold will end up being either 0 or 1 here...
danesfeder
force-pushed
the
dan-adjust-validation-thresholds
branch
from
50dd2a9 to
a17fd52
Compare
devotaaabel
approved these changes
Apr 3, 2018
Guardiola31337
requested changes
Apr 3, 2018
danesfeder
force-pushed
the
dan-adjust-validation-thresholds
branch
from
9e4a49e to
45fd1d8
Compare
Guardiola31337
approved these changes
Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced
LocationValidatorto filter incoming GPS updates. This currently has static constants as thresholds. This PR enables developers to adjust these as needed for their given requirements.