Validate route profile passed into RouteViewModel #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danesfeder
changed the title
danesfeder
force-pushed
the
dan-validate-route-profile
branch
2 times, most recently
from
9a418c5
to
8ba0179
Compare
| */ | ||
| public static boolean isValidRouteProfile(String routeProfile) { | ||
| return !TextUtils.isEmpty(routeProfile) | ||
| && routeProfile.contentEquals(DirectionsCriteria.PROFILE_DRIVING_TRAFFIC) |
There was a problem hiding this comment.
What about extracting the valid profiles into a collection and query only once (instead of 4 as is right now)? Does that make sense?
|
|
||
| assertTrue(isValidProfile); | ||
| } | ||
|
|
There was a problem hiding this comment.
It'd be great to add tests around the other valid profiles (i.e. PROFILE_DRIVING, PROFILE_CYCLING and PROFILE_WALKING).
danesfeder
force-pushed
the
dan-validate-route-profile
branch
from
8ba0179
to
307bcf5
Compare
danesfeder
force-pushed
the
dan-validate-route-profile
branch
from
f861a64
to
3e7c345
Compare
danesfeder
force-pushed
the
dan-validate-route-profile
branch
from
3e7c345
to
9b9b3e2
Compare
This was referenced Apr 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we would use whatever profile a user sets, breaking the route requests.
Found this because we were defaulting the profile to
"1"in the settings XML.