Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added null checks in case the user isn't using voice instructions #852

Merged
merged 2 commits into from
Apr 12, 2018
Merged

Added null checks in case the user isn't using voice instructions #852

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1611146
Added null checks in case the user isn't using voice instructions
Apr 11, 2018
a9500f3
Extracted code into private method and also added getInstance call to…
Apr 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...n/java/com/mapbox/services/android/navigation/v5/milestone/VoiceInstructionMilestone.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ public class VoiceInstructionMilestone extends Milestone {
public boolean isOccurring(RouteProgress previousRouteProgress, RouteProgress routeProgress) {
if (isNewRoute(routeProgress)) {
clearInstructionList();
voiceInstructionLoader.cacheInstructions(routeProgress, true);
if (voiceInstructionLoader != null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we extract this into a private method? Something like cacheInstructionsFromProgress to remove the duplicate code here?

voiceInstructionLoader.cacheInstructions(routeProgress, true);
}
}

if (shouldAddInstructions(routeProgress)) {
Expand All @@ -36,7 +38,9 @@ public boolean isOccurring(RouteProgress previousRouteProgress, RouteProgress ro

for (VoiceInstructions voice : stepVoiceInstructions) {
if (shouldBeVoiced(routeProgress, voice)) {
voiceInstructionLoader.cacheInstructions(routeProgress, false);
if (voiceInstructionLoader != null) {
voiceInstructionLoader.cacheInstructions(routeProgress, false);
}
announcement = voice.announcement();
ssmlAnnouncement = voice.ssmlAnnouncement();
stepVoiceInstructions.remove(voice);
Expand Down