Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added null check to make sure a file is actually returned #925

Merged
merged 6 commits into from
May 15, 2018
Merged

Added null check to make sure a file is actually returned #925

merged 6 commits into from
May 15, 2018

Conversation

devotaaabel
Copy link
Contributor

I had made the false assumption that this code would only be reached if a file was successfully downloaded. Now, when there is an error, onErrorDownloading is called instead of onFinishedDownloading.

Fixes #921

@devotaaabel devotaaabel added the bug Defect to be fixed. label May 7, 2018
@devotaaabel devotaaabel added this to the 0.14.0 milestone May 7, 2018
@devotaaabel devotaaabel self-assigned this May 7, 2018
@devotaaabel devotaaabel closed this May 9, 2018
@devotaaabel devotaaabel reopened this May 9, 2018
danesfeder
danesfeder approved these changes May 9, 2018
View reviewed changes
Copy link
Contributor

@danesfeder danesfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @devotaaabel

Guardiola31337
Guardiola31337 reviewed May 14, 2018
View reviewed changes
...ain/java/com/mapbox/services/android/navigation/ui/v5/voice/NavigationInstructionPlayer.java Outdated
if (instructionListener != null) {
instructionListener.onError(isMapboxPlayer);
}

if (isMapboxPlayer) { // If mapbox player failed, try android speech player
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these comments necessary?

Guardiola31337
Guardiola31337 approved these changes May 15, 2018
View reviewed changes
Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@devotaaabel devotaaabel merged commit 365a6a7 into master May 15, 2018
@devotaaabel devotaaabel deleted the devota-npe-get-path-bug branch May 15, 2018 15:03
@danesfeder danesfeder mentioned this pull request May 31, 2018
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guardiola31337 Guardiola31337 Guardiola31337 approved these changes

@danesfeder danesfeder danesfeder approved these changes

Assignees

@devotaaabel devotaaabel

Labels
bug Defect to be fixed.
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@devotaaabel @Guardiola31337 @danesfeder