Stick to chosen alternative route after rerouting proactively

[1ec5]

As of #995, we stick to the chosen route (whether the primary route or an alternative route) when rerouting due to the user going off-route. However, RouteController can still ignore this choice when proactively rerouting based on the reroutesOpportunistically option.

/ref #818
/cc @bsudekum @brsbl

[bsudekum]

checkForFasterRoute calls getDirections which does actually seek to use the most similar route:

https://github.com/mapbox/mapbox-navigation-ios/blob/master/MapboxCoreNavigation/RouteController.swift#L848

@1ec5 it looks like we are trying to stick to the same route, or am I missing something here?

[1ec5]

Did you mean to link to this method?

mapbox-navigation-ios/MapboxCoreNavigation/RouteController.swift

Line 848 in f839ae1

func updateSpokenInstructionProgress(for location: CLLocation) {

I’m not sure what it has to do with proactive rerouting.

[1ec5]

Ah, you’re right, not sure how I missed that:

mapbox-navigation-ios/MapboxCoreNavigation/RouteController.swift

Line 668 in f839ae1

getDirections(from: location) { [weak self] (route, error) in

mapbox-navigation-ios/MapboxCoreNavigation/RouteController.swift

Line 775 in f839ae1

if let route = self?.mostSimilarRoute(in: routes) {