Stick to chosen route #995
Conversation
| @@ -50,4 +50,37 @@ extension String { | |||
| var containsDecimalDigit: Bool { | |||
| return self.rangeOfCharacter(from: CharacterSet.decimalDigits) != nil | |||
| } | |||
|
|
|||
| // Adapted from https://github.com/raywenderlich/swift-algorithm-club/blob/master/Minimum%20Edit%20Distance/MinimumEditDistance.playground/Contents.swift | |||
There was a problem hiding this comment.
This code is substantially similar to that playground code. We’ll need to include this license either right here in this file or in LICENSE.md. That isn’t a problem at all, but here are two alternatives anyways:
- Write the code from scratch according to the well-documented Wagner–Fischer algorithm.
- Depend on this library instead, because it provides a Damerau–Levenshtein distance function. Unlike a basic Levenshtein distance, Damerau–Levenshtein treats a transposition (like swapping two words) as a single edit instead of a deletion and addition. We’ve had good results with this approach in a previous application.
There was a problem hiding this comment.
I'd really like to steer clear of adding another dependency. I'm 👍 on adding this to a note LICENSE.md.
There was a problem hiding this comment.
FYI, Damerau–Levenshtein is quite concise, so if adding a dependency is a problem, it shouldn’t be too difficult to port this code to Swift and add a similar MIT license block to the codebase.
|
Noting, this is a crutch until this feature is implemented on the Mapbox Directions API. |
| } | ||
| } | ||
|
|
||
| func selectRouteBySimilarity(from routes: [Route]) -> Route? { |
There was a problem hiding this comment.
This method returns a value without any side effects, so start the name with a noun, not a verb: mostSimilarRoute(in:).
Closes: #818
This PR seeks to stick to the route the user has selected when rerouting. This occurs by comparing the previous route summary to the new route(s) summary.
/cc @mapbox/navigation-ios @mapbox/navigation-android