Add stick to chosen route when re-routing with UI functionality #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
added
platform parity
Guardiola31337
force-pushed
the
pg-764-stick-to-chosen-route-ui
branch
2 times, most recently
from
4d12cb4
to
7a9db14
Compare
devotaaabel
reviewed
Mar 29, 2018
| DirectionsRoute firsRoute = routes.get(routeIndex); | ||
| String chosenRouteLegDescription = obtainRouteLegDescriptionFrom(chosenRoute); | ||
| String firstRouteLegDescription = obtainRouteLegDescriptionFrom(firsRoute); | ||
| int minSimilarity = DamerauLevenshteinAlgorithm.execute(chosenRouteLegDescription, firstRouteLegDescription); |
There was a problem hiding this comment.
why not remove this and make i = 0?
Guardiola31337
force-pushed
the
pg-764-stick-to-chosen-route-ui
branch
from
7a9db14
to
3f417da
Compare
|
Addressed your comment @devotaaabel |
danesfeder
approved these changes
Mar 30, 2018
There was a problem hiding this comment.
@Guardiola31337 this looks great. Let's keep thinking about how we can test the UI view models (in general) moving forward
Sure thing. Wasn't worth it in this case though basically because of #808 (comment)
|
devotaaabel
approved these changes
Mar 30, 2018
10 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DamerauLevenshteinAlgorithm.javais an adapted version of https://github.com/KevinStern/software-and-algorithms/blob/master/src/main/java/blogspot/software_and_algorithms/stern_library/string/DamerauLevenshteinAlgorithm.javaFixes #764
As @bsudekum mentioned in the iOS equivalent PR
cc @danesfeder @devotaaabel