Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:tag => 'v0.2.0' is not compatible with MapboxDirections 0.9.0 #148

Closed
mgurreta opened this issue Apr 15, 2017 · 2 comments · Fixed by #150
Closed

:tag => 'v0.2.0' is not compatible with MapboxDirections 0.9.0 #148

mgurreta opened this issue Apr 15, 2017 · 2 comments · Fixed by #150
Labels
build Issues related to builds and dependency management.

Comments

@mgurreta
Copy link
Contributor

RouteControllet.swift line 166

let profileIdentifier = routeProgress.route.profileIdentifier
should be
let profileIdentifier = routeProgress.route.routeOptions.profileIdentifier

@1ec5 1ec5 mentioned this issue Apr 15, 2017
@1ec5 1ec5 added the build Issues related to builds and dependency management. label Apr 15, 2017
@1ec5
Copy link
Contributor

1ec5 commented Apr 15, 2017

This is fallout from mapbox/mapbox-directions-swift#122. We merged the change suggested above in #139, but only after we tagged v0.2.0. Unfortunately, the v0.2.0 podspec was pinning to ~> 0.8 of MapboxDirections.swift instead of ~> 0.8.0. So after we released MapboxDirections.swift v0.9, CocoaPods considered v0.9 to satisfy the ~> 0.8 requirement, breaking the MapboxNavigation pod.

I’ve opened #150 with a temporary fix that more specifically depends on MapboxDirections.swift v0.8.x. I’ll tag that change as MapboxNavigation v0.2.1 and publish it to CocoaPods trunk. However, you may want to pin to a more recent commit on master in the meantime. Once the dust settles on some refactoring we’ve been doing in MapboxNavigation, we’ll publish a v0.3.0 with the fix as well.

@1ec5 1ec5 closed this as completed in #150 Apr 15, 2017
@mgurreta
Copy link
Contributor Author

you are asesome @1ec5

wishtrip-dev pushed a commit to wishtrip-dev/mapbox-navigation-ios that referenced this issue Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to builds and dependency management.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants