Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metric distances are always 0 meters in CarPlay #1853

Closed
1ec5 opened this issue Nov 22, 2018 · 0 comments
Closed

Metric distances are always 0 meters in CarPlay #1853

1ec5 opened this issue Nov 22, 2018 · 0 comments
Labels
bug Something isn’t working CarPlay Bugs, improvements and feature requests on Apple CarPlay topic: instructions topic: localization
Milestone
v0.25.0

Comments

@1ec5
Copy link
Contributor

1ec5 commented Nov 22, 2018

When the application region is set to a region that uses the metric system, the distance to the maneuver in CarPlay is always shown as “0 m”, regardless of the actual distance:

0 m

The issue appears to be related to rounding thresholds.

mapbox-navigation-ios/MapboxCoreNavigation/DistanceFormatter.swift

Line 217 in cc255c4

numberFormatter.roundingIncrement = threshold.roundingIncrement as NSNumber

/ref #681
/cc @frederoni @JThramer
@1ec5 1ec5 added bug Something isn’t working topic: instructions topic: localization CarPlay Bugs, improvements and feature requests on Apple CarPlay labels Nov 22, 2018
@1ec5 1ec5 added this to the v0.25.0 milestone Nov 22, 2018
@1ec5 1ec5 mentioned this issue Nov 22, 2018
Merged
@1ec5 1ec5 mentioned this issue Nov 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn’t working CarPlay Bugs, improvements and feature requests on Apple CarPlay topic: instructions topic: localization
Projects
None yet
Milestone
v0.25.0
Development

No branches or pull requests
1 participant
@1ec5