Fix metric measurements in CarPlay #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
added
bug
1ec5
force-pushed
the
1ec5-carplay-meter-redefinition-1853
branch
from
27854ca
to
a77f5f3
Compare
frederoni
reviewed
Nov 22, 2018
| case .meter: | ||
| return Measurement(value: distance.kilometers / 1e3, unit: .meters) | ||
| return Measurement(value: distance.kilometers * 1e3, unit: .meters) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
frederoni
approved these changes
Nov 22, 2018
1ec5
force-pushed
the
1ec5-carplay-meter-redefinition-1853
branch
from
a77f5f3
to
84f5a98
Compare
1ec5
force-pushed
the
1ec5-carplay-meter-redefinition-1853
branch
from
84f5a98
to
2cd1f15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CarPlay, the meter is once again defined as the distance such that the speed of light in vacuum c is 299 792 458 when expressed in meters per second, where the second is defined in terms of the cesium frequency ΔνCs. Likewise with the centimeter and millimeter.
Fixes #1853.
/cc @frederoni @JThramer