Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields missing in CarPlay simulator #1867

Closed
1ec5 opened this issue Nov 30, 2018 · 3 comments · Fixed by #1868
Closed

Shields missing in CarPlay simulator #1867

1ec5 opened this issue Nov 30, 2018 · 3 comments · Fixed by #1868
Assignees
Labels
bug Something isn’t working CarPlay Bugs, improvements and feature requests on Apple CarPlay topic: instructions
Milestone

Comments

@1ec5
Copy link
Contributor

1ec5 commented Nov 30, 2018

Route shields and exit numbers don’t appear in turn-by-turn mode in the CarPlay simulator, even though they show up in CarPlay devices.

/ref #1652 (comment)
/cc @JThramer

@1ec5 1ec5 added bug Something isn’t working topic: instructions CarPlay Bugs, improvements and feature requests on Apple CarPlay labels Nov 30, 2018
@1ec5 1ec5 added this to the v0.26.0 milestone Nov 30, 2018
@1ec5 1ec5 self-assigned this Nov 30, 2018
@1ec5
Copy link
Contributor Author

1ec5 commented Nov 30, 2018

Hard-coding an image size of 16×16 points in UIView.imageRepresentation makes the image show up in the CarPlay simulator, which strongly suggests to me that this issue and #1866 are both caused by images exceeding an undocumented maximum image size in text attachments in attributed instruction strings in CarPlay.

let size = CGSize(width: frame.size.width, height: frame.size.height)

16

@akitchen
Copy link
Contributor

huh... 🤔 I wonder if it's related to the line height of the font being used, etc. I recommend enabling the extended carplay simulator options and trying different form factors & pixel depths

nice catch!

@1ec5
Copy link
Contributor Author

1ec5 commented Nov 30, 2018

CarPlay ignores font and paragraph attributes in attributedInstructionVariants. NSAttributedString is only used for embedding text attachments in the instruction. Given that there are size limits to all the other image assets that go over the (presumably XPC-like) communication protocol, it doesn’t surprise me that text attachments also have a height limit of 16 points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn’t working CarPlay Bugs, improvements and feature requests on Apple CarPlay topic: instructions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants