Downsize shields in instructions in CarPlay #1868
Conversation
1ec5
added
bug
| @@ -316,6 +316,13 @@ public class CarPlayNavigationViewController: UIViewController { | |||
| return CGRect(x: 0, y: 0, width: widthOfManeuverView, height: 30) | |||
| } | |||
|
|
|||
| // Over a certain height, CarPlay devices downsize the image and CarPlay simulators hide the image. | |||
| let maximumImageSize = CGSize(width: .infinity, height: shieldHeight) | |||
There was a problem hiding this comment.
IIRC, the max height of an attachment in an attributed string drawn by a UILabel should be font.size.height + font.ascender + font.descender.
There was a problem hiding this comment.
Is that maximum height a best practice or a hard limit? In my testing, I kept seeing a hard 16-point height limit, but is there a way to change the font size in CarPlay? Perhaps an accessibility setting?
There was a problem hiding this comment.
As far as I can tell, none of the accessibility settings on iOS affect the font size of the instructions in CarPlay. CarPlay units do have their own settings (such as the left/right layout setting), but I haven’t seen a setting about the font size in the units I’ve used so far.
There was a problem hiding this comment.
Hard limit before image gets cropped or scaled depending on other attributes. I thought we had some leeway but, if there seem to be a 16p limit, let's stick with that.
When preparing attributed instruction strings for CarPlay, resize any text attachment image taller than 16 points, preserving the aspect ratio.
1ec5
force-pushed
the
1ec5-carplay-shield-size-1867
branch
from
424c414
to
bdc00d3
Compare
When preparing attributed instruction strings for CarPlay, resize any text attachment image taller than 16 points, preserving the aspect ratio.
Here’s a before and after:
Shields on the phone are unaffected:
Fixes #1867 and speculatively fixes #1866. A more correct fix for #1866 would require adjustments to the constraints in ExitView and GenericRouteShield.
/cc @mapbox/navigation-ios