-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lane icons need to handle more lane configurations #576
Comments
@bhousel made a bunch of scalable vector turn lane icons that closely match the style we’re using: openstreetmap/lane-icons#1. |
Disclaimer: I haven't actually made them yet :) I do have an illustrator file sitting somewhere. Ballpark estimate, what kind of resolution would you show them at? We realized that we'd need to design very different icons for tiny and large sizes (arrowheads are complicated). |
30 points × 30 points:
Note that we designed the lane arrow icons in PaintCode and exported them as Swift code (on iOS; Java code on Android). PaintCode can import SVG, but mainly I mentioned openstreetmap/lane-icons#1 to provide a sense of the combinations that are required. |
Tracking the actual artwork in mapbox/navigation-ui-resources#8. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Still blocked upstream. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
No longer blocked as of mapbox/navigation-ui-resources#21. |
#2801 tracks selecting the turn lane icon with less guessing; that change would have a much greater impact if we can support the common configurations listed in #576 (comment). mapbox/navigation-ui-resources#21 adds these and several somewhat less common configurations. In order to support any of the new assets, a new StyleKit will need to be exported from PaintCode and the calls to it in LaneView will need to be updated. |
Fixed in #2882 on the release-v2.0 branch for v2.0.0. |
LaneArrowView.draw(_:)
omits some common lane indication scenarios, which means we probably give misleading information in those cases:left;through;right
in theturn:lanes
tag, which maps to aLaneIndication
of[.left, .straight, .right]
in MapboxDirections.swift (example). There are alsoreverse;left;through
lanes in some places.reverse;left
, which maps to[.uTurn, .left]
. For any step that requires a U-turn, this becomes relevant for situations likereverse;left|left
, when a lane that allows U-turns and left turns is next to a lane that allows only left turns – the driver needs to get into the leftmost lane, not the two left lanes.left;right
, which maps to[.left, .right]
(example; open iD to see the pavement marking). This is especially common at a T-intersection or where a road becomes a one-way road.The U.S. signs above are based on the following standard:
http://mutcd.fhwa.dot.gov/SHSe/Regulatory.pdf#page=29
http://mutcd.fhwa.dot.gov/SHSe/Regulatory.pdf#page=62
Commons has plenty of SVGs of U.S. and European lane control signs that we can repurpose for this UI:
https://commons.wikimedia.org/wiki/Category:Lane_turning_road_signs
https://commons.wikimedia.org/wiki/Category:Mandatory_direction_road_signs
https://commons.wikimedia.org/wiki/Category:R3-6_-_Optional_Movement_Lane_Control
https://commons.wikimedia.org/wiki/Category:R3-18_-_No_Left_or_U_turn
/cc @bsudekum @mayagao @frederoni @daniel-j-h @danesfeder @ericrwolfe
The text was updated successfully, but these errors were encountered: