Always send progress update except when location is unqualified #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
added
the
backwards incompatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the notification key
MBRouteControllerEstimatedTimeUntilManeuverKeyin favor of using durationRemaining oncurrentStepProgress, and makes sure progress updates are always fired when the location is deemed qualified.When a user begins to go off route near a maneuver, this check
if distanceTraveled != currentStepProgress.distanceTraveled {would fail because the distance traveled is a snapped distance. Although the distance is not changing, we still need to emit progress updates. This was not surfaced because we're updating the user puck via this delegate method instead of progress update notifications. This is important for developers who are implementing custom UIs./cc @mapbox/navigation-ios