Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable night style when inside tunnel #1127

Merged
merged 62 commits into from
Mar 13, 2018
Merged

Enable night style when inside tunnel #1127

merged 62 commits into from
Mar 13, 2018

Commits on Feb 17, 2018

  1. Added ability to detect commuter is in a tunnel and automatically ena… 

    …ble dark mode upon entrance and reset to default style mode upon exit.
    @vincethecoder
    vincethecoder committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    d2581fc View commit details
    Browse the repository at this point in the history

  2. Minor code refactor for tunnel intersection.

    @vincethecoder
    vincethecoder committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    0a67127 View commit details
    Browse the repository at this point in the history

  3. Minor grammatical updates to comments on route step tunnel intersection.

    @vincethecoder
    vincethecoder committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    52564d6 View commit details
    Browse the repository at this point in the history

  4. Minor text updates.

    @vincethecoder
    vincethecoder committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    2f67660 View commit details
    Browse the repository at this point in the history

  5. Added comments to explain preconditions to capture all locations that… 

    … lie within the tunnel route.
    @vincethecoder
    vincethecoder committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    72fee83 View commit details
    Browse the repository at this point in the history

  6. Removed console logs for debug purposes.

    @vincethecoder
    vincethecoder committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    1b0e577 View commit details
    Browse the repository at this point in the history

  7. Removed resetTimeOfDayTimer method, as styles are automatically adjus… 

    …ted by styleManager's styles property.
    @vincethecoder
    vincethecoder committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    14c5b8e View commit details
    Browse the repository at this point in the history

  8. Updated style manager to apply custom styles.

    @vincethecoder
    vincethecoder committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    d764421 View commit details
    Browse the repository at this point in the history

  9. Set style to night style when in tunnel.

    @vincethecoder
    vincethecoder committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    dc482f7 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2018

  1. A few enhancement/refsctor for routestep and routecontroller discover… 

    …ing tunnel on route step.
    @vincethecoder
    vincethecoder committed Feb 18, 2018
    Configuration menu
    Copy the full SHA
    1b1152a View commit details
    Browse the repository at this point in the history

  2. Updated logic for setting a custom style.

    @vincethecoder
    vincethecoder committed Feb 18, 2018
    Configuration menu
    Copy the full SHA
    19ac74d View commit details
    Browse the repository at this point in the history

  3. Modified delegate method to enable tunnel dark mode when commuter ent… 

    …ers a tunnel.
    @vincethecoder
    vincethecoder committed Feb 18, 2018
    Configuration menu
    Copy the full SHA
    f81319b View commit details
    Browse the repository at this point in the history

  4. Added function to apply a specific style type.

    @vincethecoder
    vincethecoder committed Feb 18, 2018
    Configuration menu
    Copy the full SHA
    aadadf4 View commit details
    Browse the repository at this point in the history

  5. Added a break to the for-loop for retrieving the desired style type.

    @vincethecoder
    vincethecoder committed Feb 18, 2018
    Configuration menu
    Copy the full SHA
    181b428 View commit details
    Browse the repository at this point in the history

  6. corrected grammatical error

    @vincethecoder
    vincethecoder committed Feb 18, 2018
    Configuration menu
    Copy the full SHA
    5198ce4 View commit details
    Browse the repository at this point in the history

  7. Removed extra spaces

    @vincethecoder
    vincethecoder committed Feb 18, 2018
    Configuration menu
    Copy the full SHA
    b2b0186 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'tunnel/dark_mode_style' of github.com:mapbox/mapbox-nav… 

    …igation-ios into tunnel/dark_mode_style
    @vincethecoder
    vincethecoder committed Feb 18, 2018
    Configuration menu
    Copy the full SHA
    05ef98f View commit details
    Browse the repository at this point in the history

  9. Refactored condition limit to 2

    @vincethecoder
    vincethecoder committed Feb 18, 2018
    Configuration menu
    Copy the full SHA
    bb89fff View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2018

  1. A few updates for when a tunnel is detected.

    @vincethecoder
    vincethecoder committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    613fdfc View commit details
    Browse the repository at this point in the history

  2. Refactored function - applyStyle()

    @vincethecoder
    vincethecoder committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    8caa01a View commit details
    Browse the repository at this point in the history

  3. Minor text updates

    @vincethecoder
    vincethecoder committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    c1d95d5 View commit details
    Browse the repository at this point in the history

  4. Removed break in style apply function.

    @vincethecoder
    vincethecoder committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    efc7527 View commit details
    Browse the repository at this point in the history

  5. Updated tunnelIntersectionBounds to check index bounds before accessi… 

    …ng i+1
    @vincethecoder
    vincethecoder committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    256e154 View commit details
    Browse the repository at this point in the history

  6. Updated the check for intersection count.

    @vincethecoder
    vincethecoder committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    7686d52 View commit details
    Browse the repository at this point in the history

  7. Revised the absolute tunnel distance calculation to use Polyline meth… 

    …od distance(from:to:)
    @vincethecoder
    vincethecoder committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    b8f8a9e View commit details
    Browse the repository at this point in the history

  8. Reversed variables around for distance to entrance.

    @vincethecoder
    vincethecoder committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    cf306ca View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2018

  1. Updated route controller delegate methods to detect when tunnel was e… 

    …ntered and existed.
    @vincethecoder
    vincethecoder committed Feb 21, 2018
    Configuration menu
    Copy the full SHA
    c7513bf View commit details
    Browse the repository at this point in the history

  2. Updated changelog file with new delegate methods that detects when a … 

    …commuter enters and exits a tunnel on route.
    @vincethecoder
    vincethecoder committed Feb 21, 2018
    Configuration menu
    Copy the full SHA
    fb959c8 View commit details
    Browse the repository at this point in the history

  3. Revised logic to accommodate a single intersection on tunnel route.

    @vincethecoder
    vincethecoder committed Feb 21, 2018
    Configuration menu
    Copy the full SHA
    6915af5 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2018

  1. Added logic to handle navigation through multiple tunnels on a route.

    @vincethecoder
    vincethecoder committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    e5058e6 View commit details
    Browse the repository at this point in the history

  2. Removed extra lines of code to enhance readability

    @vincethecoder
    vincethecoder committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    f7463d4 View commit details
    Browse the repository at this point in the history

  3. Updated change log to reference link to PR

    @vincethecoder
    vincethecoder committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    232baa4 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into tunnel/dark_mode_style 

    # Conflicts:
#	CHANGELOG.md
    @vincethecoder
    vincethecoder committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    64a7897 View commit details
    Browse the repository at this point in the history

  5. Minor refactor for array to use the defined typealias - IntersectionB… 

    …ounds
    @vincethecoder
    vincethecoder committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    4e5356a View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2018

  1. Updated the function to detect intersection bounds on a route.

    @vincethecoder
    vincethecoder committed Feb 26, 2018
    Configuration menu
    Copy the full SHA
    be3cf6b View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2018

  1. Updates to cache and calculate the intersection bounds for detecting … 

    …when commuter did enter/exit a tunnel
    @vincethecoder
    vincethecoder committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    18160da View commit details
    Browse the repository at this point in the history

  2. Moved variable up to the top of the extension.

    @vincethecoder
    vincethecoder committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    af050d4 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2018

  1. Made updates based on PR feedback.

    @vincethecoder
    vincethecoder committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    e48ad83 View commit details
    Browse the repository at this point in the history

  2. Readded deleted function updateSpokenInstructionProgress(for:)

    @vincethecoder
    vincethecoder committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    3d1ef3f View commit details
    Browse the repository at this point in the history

  3. Updated the change log to reflect new changes.

    @vincethecoder
    vincethecoder committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    da0ab08 View commit details
    Browse the repository at this point in the history

  4. Updates to set intersectionDistances on RouteProgress class. Modifed … 

    …the change log.
    @vincethecoder
    vincethecoder committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    82c8310 View commit details
    Browse the repository at this point in the history

  5. Updated the bounds check on currentIntersection and upcomingIntersection

    @vincethecoder
    vincethecoder committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    4518a12 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2018

  1. Restrict the intersection index to 0 base.

    @vincethecoder
    vincethecoder committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    49a5817 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into tunnel/dark_mode_style

    @vincethecoder
    vincethecoder committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    2b5cd86 View commit details
    Browse the repository at this point in the history

  3. Added a restriction for the minimum distance of a tunnel intersection… 

    … prior to switching on dark style.
    @vincethecoder
    vincethecoder committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    f25448f View commit details
    Browse the repository at this point in the history

  4. Turf import is unnecessary.

    @vincethecoder
    vincethecoder committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    59b25b3 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2018

  1. Removed valid adjective

    @vincethecoder
    vincethecoder committed Mar 3, 2018
    Configuration menu
    Copy the full SHA
    0b93231 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2018

  1. Updates to tunnel work change log file

    @vincethecoder
    vincethecoder committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    f71f649 View commit details
    Browse the repository at this point in the history

  2. Added function to force refresh of appearance.

    @vincethecoder
    vincethecoder committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    8f24774 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2018

  1. Added a constant to MBNavigation constants file. Removed irrelevant p… 

    …roperties from routeprogress.
    @vincethecoder
    vincethecoder committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    0b44f03 View commit details
    Browse the repository at this point in the history

  2. Added a feature flag to detect when to switch styles for tunnels.

    @vincethecoder
    vincethecoder committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    3675974 View commit details
    Browse the repository at this point in the history

  3. Deleted extra white space.

    @vincethecoder
    vincethecoder committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    2acde88 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2018

  1. Minor refactor

    @vincethecoder
    vincethecoder committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    241bba6 View commit details
    Browse the repository at this point in the history

  2. Updated the change logs with a note regarding new fields for current … 

    …and upcoming intersections, along with their corresponding calculated distances.
    @vincethecoder
    vincethecoder committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    4ad24d0 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2018

  1. Updates to use a CountableClosedRange on the conditional check on int… 

    …ersections bounds. Modified description text for current and upcoming intersections. Modified variable to indicate when night style should be enabled inside a tunnel.
    @vincethecoder
    vincethecoder committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    6ef815c View commit details
    Browse the repository at this point in the history

  2. Updates to use a CountableClosedRange on the conditional check on int… 

    …ersections bounds.
    @vincethecoder
    vincethecoder committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    f0411b8 View commit details
    Browse the repository at this point in the history

  3. Reverted updates to use a CountableClosedRange on the conditional che… 

    …ck on intersections bounds to initial state.
    @vincethecoder
    vincethecoder committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    5ecb164 View commit details
    Browse the repository at this point in the history

  4. Updates to use a CountableClosedRange on the conditional check on int… 

    …ersections bounds.
    @vincethecoder
    vincethecoder committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    36a374a View commit details
    Browse the repository at this point in the history

  5. Reverted updates to use a CountableClosedRange on the conditional che… 

    …ck on intersections bounds to initial state.
    @vincethecoder
    vincethecoder committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    cb8a46b View commit details
    Browse the repository at this point in the history

  6. Added dead reckoning flag to restrict intersection calculations on th… 

    …e route controller.
    @vincethecoder
    vincethecoder committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    709231e View commit details
    Browse the repository at this point in the history

  7. Refactored code into functions and renamed feature flag for switching… 

    … on night style in tunnels.
    @vincethecoder
    vincethecoder committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    70c5e76 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2018

  1. Merge branch 'master' into tunnel/dark_mode_style

    @vincethecoder
    vincethecoder committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    9c878c3 View commit details
    Browse the repository at this point in the history