Fix memory leaks #120
Merged
Fix memory leaks #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsudekum
reviewed
Apr 7, 2017
| @@ -262,7 +264,6 @@ public class RouteViewController: NavigationPulleyViewController { | |||
|
|
|||
| extension RouteViewController: RouteTableViewHeaderViewDelegate { | |||
| func didTapCancel() { | |||
| voiceController = nil | |||
|
@DenHeadless, looks good to me. @1ec5 have a second to give this a once over? |
1ec5
approved these changes
Apr 8, 2017
wishtrip-dev
pushed a commit
to wishtrip-dev/mapbox-navigation-ios
that referenced
this pull request
Feb 28, 2018
Mapbox iOS SDK v3.5.0, OHHTTPStubs master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
This PR fixes various memory leaks, that prevents several MapboxNavigationUI components from being deallocated.
Three of them are usual non-weak delegate suspects.
Two more are NSTimer instances retaining their target until invalidated. I chose to invalidate them in RouteViewController deinit, since after main controller deinit probably there's no use in them