Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reroute proactively, not opportunistically #1230

Merged
merged 1 commit into from
Mar 16, 2018
Merged

Reroute proactively, not opportunistically #1230

merged 1 commit into from
Mar 16, 2018

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Mar 16, 2018

“Opportunistic” can have a negative connotation. The automatic rerouting feature is just trying to be helpful, proactively. So the following symbols have been renamed:

  • RouteController.reroutesOpportunistically to RouteController.reroutesProactively
  • RouteControllerOpportunisticReroutingInterval to RouteControllerProactiveReroutingInterval
  • RouteControllerNotificationUserInfoKey.isOpportunisticKey to RouteControllerNotificationUserInfoKey.isProactiveKey

/cc @bsudekum

@1ec5 1ec5 added op-ex Refactoring, Tech Debt or any other operational excellence work. topic: location labels Mar 16, 2018
@1ec5 1ec5 self-assigned this Mar 16, 2018
@1ec5 1ec5 requested a review from bsudekum March 16, 2018 01:28
JThramer
JThramer approved these changes Mar 16, 2018
View reviewed changes
Copy link
Contributor

@JThramer JThramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR

CHANGELOG.md
@@ -2,10 +2,13 @@

## Master

#### User Interface
#### User interface
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we Caps-casing everything but "User interface"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything should be in sentence case. “Core Navigation” is a framework name, so it just looks like title case.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha! Totally makes sense.

@1ec5 1ec5 merged commit 72c2a57 into master Mar 16, 2018
@1ec5 1ec5 deleted the 1ec5-proactive-rerouting branch March 16, 2018 19:43
@1ec5 1ec5 added the backwards incompatible changes that break backwards compatibility of public API label Dec 18, 2018
@1ec5 1ec5 added this to the v0.16.0 milestone Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JThramer JThramer JThramer approved these changes

@bsudekum bsudekum Awaiting requested review from bsudekum

Assignees

@1ec5 1ec5

Labels
backwards incompatible changes that break backwards compatibility of public API op-ex Refactoring, Tech Debt or any other operational excellence work. topic: location
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@1ec5 @JThramer