-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draw slight left/right lanes #1270
Conversation
fad4cb6
to
488525e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also verify the road class?
It’s possible for the end of a motorway
to have ordinary turn lanes. There are some prominent signalized freeway ends in Washington, D.C., and San Francisco, for example. I think it would be more reliable to treat right
as slightRight
if the maneuver type is takeOffRamp
or reachFork
.
488525e
to
3e3f710
Compare
@@ -1,6 +1,6 @@ | |||
import XCTest | |||
import FBSnapshotTestCase | |||
import MapboxDirections | |||
@testable import MapboxDirections |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting the error: Module 'MapboxDirections' was not compiled for testing
Does something need to change in the cartfile to make this happen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this @testable
needed? This PR doesn’t seem to introduce any calls to private methods.
Never mind, it’s Lane(indications:)
. Maybe we should make that initializer public. It’s a good practice to always make at least one initializer public for any class, to facilitate unit testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this init is private: https://github.com/mapbox/mapbox-navigation-ios/pull/1270/files#diff-ec73732e527cb329ec167966c37b7cbeR50
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what the best practice is here but testable imports publicizes private methods in frameworks built with its configuration set to debug (carthage update/bootstrap --configuration Debug
) so we can keep the initializer private.
Fixes #1267 show slight arrows on freeway lanes
Should we also verify the road class? 🤔
@1ec5 @bsudekum 👀