Expose RouteController.routeProgress to Objective-C #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
approved these changes
Apr 23, 2018
| @@ -185,7 +185,7 @@ open class RouteController: NSObject { | |||
| /** | |||
| Details about the user’s progress along the current route, leg, and step. | |||
| */ | |||
| public var routeProgress: RouteProgress { | |||
| @objc public var routeProgress: RouteProgress { | |||
There was a problem hiding this comment.
Besides exposing the property to Objective-C, this change also switches the property’s getter and setter to use Objective-C method dispatch. The willSet and didSet should continue to work just like before, but it’s worth double-checking to be sure.
There was a problem hiding this comment.
4f21e5a verifies that the notification in the property’s didSet gets fired.
|
Hi Frederoni, sorry to ask stupid question. Which mean that now I need to update my CocoaPods |
|
@tester87 correct, that fix is included in v0.17.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1320 Make it possible to update route from Objective-C
@mapbox/navigation-ios 👀