Fix setOverheadCameraView for short routes #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1030,14 +1030,25 @@ open class NavigationMapView: MGLMapView, UIGestureRecognizerDelegate { | |||
| let line = MGLPolyline(coordinates: slicedLine, count: UInt(slicedLine.count)) | |||
|
|
|||
| tracksUserCourse = false | |||
|
|
|||
| // If the user has a short distance left on the route, prevent the camera from zooming all the way. | |||
| // `MGLMapView.setVisibleCoordinateBounds(:edgePadding:animated:)` will go beyond what is convient for the driver. | |||
There was a problem hiding this comment.
will go beyond what is convient for the driver.
did you mean to say convenient to the driver?
There was a problem hiding this comment.
Yeah, it'd be inconvenient for the map to continue zooming past what is comprehensible.
There was a problem hiding this comment.
@bsudekum oh okay. There's a typo convient for should convenient to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the bug in #1455
Previously, if the user only had a few meters left on the route, we'd flip up the camera, then break early and never actually set the correct center coordinate.
Now, if we detect there is not much left on the route, we simple flip the camera and set the center coordinates to the user.
/cc @mapbox/navigation-ios